-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add enabled_features to the heartbeat document #399
Conversation
}, | ||
"Endpoint": { | ||
"state": { | ||
"enabled_features": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeypoon what do you think of this exact location? Endpoint.state.host_isolation=true|false
already exists. It felt like this belonged along side it conceptually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, assuming the removal from custom_documentation
was intentional
I tested this and it works with upcoming Endpoint changes to add this data. |
Change Summary
Adds
Endpoint.state.enabled_features
to the heartbeat document. I removed thecustom_documentation
since these are moving to a.logs
data stream.Sample values
See PR content.
Release Target
8.10
Q/A
For mapping changes:
make
after making the schema changes, and committed all changes