Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add enabled_features to the heartbeat document #399

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

ferullo
Copy link
Contributor

@ferullo ferullo commented Aug 3, 2023

Change Summary

Adds Endpoint.state.enabled_features to the heartbeat document. I removed the custom_documentation since these are moving to a .logs data stream.

Sample values

See PR content.

Release Target

8.10

Q/A

For mapping changes:

  • I ran make after making the schema changes, and committed all changes

@ferullo ferullo requested a review from a team as a code owner August 3, 2023 19:12
},
"Endpoint": {
"state": {
"enabled_features": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeypoon what do you think of this exact location? Endpoint.state.host_isolation=true|false already exists. It felt like this belonged along side it conceptually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense to me 👍

Copy link
Member

@pzl pzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, assuming the removal from custom_documentation was intentional

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-03T19:12:34.327+0000

  • Duration: 8 min 34 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ferullo
Copy link
Contributor Author

ferullo commented Aug 4, 2023

I tested this and it works with upcoming Endpoint changes to add this data.

@ferullo ferullo merged commit c55f178 into main Aug 4, 2023
@ferullo ferullo deleted the heartbeat-enabled-features branch August 4, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants